Implementation of ASN regions of interest (ROIs)#52
Open
martijnende wants to merge 1 commit intoxdas-dev:devfrom
Open
Implementation of ASN regions of interest (ROIs)#52martijnende wants to merge 1 commit intoxdas-dev:devfrom
martijnende wants to merge 1 commit intoxdas-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the ASN OptoDAS it is possible to define multiple ROIs on a single fibre, or use the multiplexer to sense multiple fibres simultaneously. These ROIs are concatenated in a single data file without obvious demarcation. The goal of this PR is to implement some logic to split the data into virtual segments that are more easily labelled and accessed from a
DataMappingobject.